netdev - Re: [Intel-wired-lan] [PATCH iwl-net v4 6/6] igc: add lock preventing multiple simultaneous PTM transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0128dcc-5d8f-40a6-ac7b-67febd72fea4@intel.com>
Date: Thu, 10 Apr 2025 15:14:19 +0300
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Jacob Keller <jacob.e.keller@...el.com>, Anthony Nguyen
	<anthony.l.nguyen@...el.com>
CC: <david.zage@...el.com>, <vinicius.gomes@...el.com>,
	<rodrigo.cadore@...coustics.com>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>, Christopher S M Hall
	<christopher.s.hall@...el.com>, Corinna Vinschen <vinschen@...hat.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4 6/6] igc: add lock preventing
 multiple simultaneous PTM transactions

On 02/04/2025 2:35, Jacob Keller wrote:
> From: Christopher S M Hall <christopher.s.hall@...el.com>
> 
> Add a mutex around the PTM transaction to prevent multiple transactors
> 
> Multiple processes try to initiate a PTM transaction, one or all may
> fail. This can be reproduced by running two instances of the
> following:
> 
> $ sudo phc2sys -O 0 -i tsn0 -m
> 
> PHC2SYS exits with:
> 
> "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction
>   fails
> 
> Note: Normally two instance of PHC2SYS will not run, but one process
>   should not break another.
> 
> Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
> Signed-off-by: Christopher S M Hall <christopher.s.hall@...el.com>
> Reviewed-by: Corinna Vinschen <vinschen@...hat.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>   drivers/net/ethernet/intel/igc/igc.h     |  1 +
>   drivers/net/ethernet/intel/igc/igc_ptp.c | 20 ++++++++++++++++++--
>   2 files changed, 19 insertions(+), 2 deletions(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>