Message-ID: <CANn89iJQ1Qkby8gFsWHnuYyHYO7_vasNom52OSMAGN49s5EkzQ@mail.gmail.com>
Date: Thu, 10 Apr 2025 15:31:47 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Sven Eckelmann <sven@...fation.org>
Cc: Simon Wunderlich <sw@...onwunderlich.de>, Paolo Abeni <pabeni@...hat.com>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH net v3] batman-adv: Fix double-hold of meshif when getting enabled

On Thu, Apr 10, 2025 at 3:08 PM Sven Eckelmann <sven@...fation.org> wrote:
>
> On Thursday, 10 April 2025 12:13:25 CEST Paolo Abeni wrote:
> > Also this is somewhat strange: the same patch come from 2 different
> > persons (sometimes with garbled SoBs),
>
> Ok, all of that was my fault. Even the original duplicated *dev_hold. Just as summary:
>
> * v1: accidentally submitted the patch with correct content but from a test
>   git repo which didn't had the actual commit message
> * v2: send correct patch but it was done from the folder which is used to
>   prepare the branches which will be submitted later by Simon -> git-send-
>   email picked up the Simon's name (see below) and submitted it using my
>   mailserver
> * v3: submitted it "correctly" and marked the day as "shouldn't have waken up
>   in the first place"
>
> Regarding the v2 situation: This is definitely odd but it had to be done this
> way because there were complains in the past from netdev when Simon submitted
> the PR and not all patches in the PR were Signed-off-by him. As result, when I
> add something in the queue, I directly apply the patches as him (including my
> own Signed-off-by). And Simon will go through the patches again before
> actually sending the PR, create a signed tag and submits the PR. I would love
> not to do this preparation/fakery anymore. But then you will not have the
> requested full signed-off-by - something which you usually don't have for PRs
> but which was for some reason required for netdev.
>
> > and we usually receive PR for
> > batman patches.
>
> This was just an attempt to get syzbot happy again (sooner). Besides my direct
> patch submission, we have different options:
>
> * wait for Simon's PR
> * let Eric Dumazet integrate his (earlier posted) patch from
>   https://lore.kernel.org/r/CANn89iJTHf-sJCqcyrFJiLMLBOBgtN0+KrfPSuW0mhOzLS08Rw@mail.gmail.com
>   This change was also published earlier
>
> > Also I do not see credits given to syzbot  team ?
>
> Correct. Is there a proper way when the reports received were actually about
> different problems (just the bisecting went the wrong way due to the
> batman-adv bug)?
>
> For example, I saw the problem with bisecting in:
>
> * https://syzkaller.appspot.com/bug?extid=ff3aa851d46ab82953a3
>   Reported-by: syzbot+ff3aa851d46ab82953a3@...kaller.appspotmail.com
> * https://syzkaller.appspot.com/bug?extid=4036165fc595a74b09b2
>   Reported-by: syzbot+4036165fc595a74b09b2@...kaller.appspotmail.com
> * https://syzkaller.appspot.com/bug?extid=c35d73ce910d86c0026e
>   Reported-by: syzbot+c35d73ce910d86c0026e@...kaller.appspotmail.com
> * https://syzkaller.appspot.com/bug?extid=48c14f61594bdfadb086
>   Reported-by: syzbot+48c14f61594bdfadb086@...kaller.appspotmail.com
>
> So, a lot of different problems which unfortunately all ended up in bisecting
> to the batman-adv problem.
>
> On Thursday, 10 April 2025 13:20:21 CEST Eric Dumazet wrote:
> > https://lkml.org/lkml/2025/4/8/1988
>
> You also posted your patch here. Feel free to directly add it. And sorry for
> adding the problem in the first placed - just tried to make Antonio happy (and
> then created a big mess for everyone else)

No worries, could you post the fix today with some of the
Reported-by: you are aware of ?

You can add a 'Suggested-by: Eric Dumazet <edumazet@...gle.com>'

Thanks !

Powered by blists - more mailing lists