netdev - Re: [PATCH net] ipv6: add exception routes to GC list in rt6_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <041b254d-30ed-4532-ab1a-45006a17597d@kernel.org>
Date: Thu, 10 Apr 2025 09:04:12 -0600
From: David Ahern <dsahern@...nel.org>
To: Xin Long <lucien.xin@...il.com>, network dev <netdev@...r.kernel.org>
Cc: davem@...emloft.net, kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Kui-Feng Lee <thinker.li@...il.com>
Subject: Re: [PATCH net] ipv6: add exception routes to GC list in
 rt6_insert_exception

On 4/8/25 11:46 AM, Xin Long wrote:
> Commit 5eb902b8e719 ("net/ipv6: Remove expired routes with a separated list
> of routes.") introduced a separated list for managing route expiration via
> the GC timer.
> 
> However, it missed adding exception routes (created by ip6_rt_update_pmtu()
> and rt6_do_redirect()) to this GC list. As a result, these exceptions were
> never considered for expiration and removal, leading to stale entries
> persisting in the routing table.
> 
> This patch fixes the issue by calling fib6_add_gc_list() in
> rt6_insert_exception(), ensuring that exception routes are properly tracked
> and garbage collected when expired.
> 
> Fixes: 5eb902b8e719 ("net/ipv6: Remove expired routes with a separated list of routes.")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  net/ipv6/route.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index ab12b816ab94..99903c6a39fa 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1771,6 +1771,7 @@ static int rt6_insert_exception(struct rt6_info *nrt,
>  	if (!err) {
>  		spin_lock_bh(&f6i->fib6_table->tb6_lock);
>  		fib6_update_sernum(net, f6i);
> +		fib6_add_gc_list(f6i);
>  		spin_unlock_bh(&f6i->fib6_table->tb6_lock);
>  		fib6_force_start_gc(net);
>  	}

Reviewed-by: David Ahern <dsahern@...nel.org>