netdev - Re: [PATCH iwl-net v3] ice: use DSN instead of PCI BDF for ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250410154353.GU395307@horms.kernel.org>
Date: Thu, 10 Apr 2025 16:43:53 +0100
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
	Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
	Jacob Keller <jacob.e.keller@...el.com>,
	Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>,
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
	Karol Kolacinski <karol.kolacinski@...el.com>,
	Grzegorz Nitka <grzegorz.nitka@...el.com>,
	Michal Schmidt <mschmidt@...hat.com>,
	Sergey Temerkhanov <sergey.temerkhanov@...el.com>,
	Michal Kubiak <michal.kubiak@...el.com>
Subject: Re: [PATCH iwl-net v3] ice: use DSN instead of PCI BDF for
 ice_adapter index

On Tue, Apr 08, 2025 at 03:46:55PM +0200, Przemek Kitszel wrote:
> Use Device Serial Number instead of PCI bus/device/function for
> index of struct ice_adapter.
> Functions on the same physical device should point to the very same
> ice_adapter instance.
> 
> This is not only simplification, but also fixes things up when PF
> is passed to VM (and thus has a random BDF).

Maybe it's just me but "fixes things up" seems a bit vague for
a fix for net. Could something more specific go here?

> 
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Suggested-by: Jiri Pirko <jiri@...nulli.us>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> CC: Karol Kolacinski <karol.kolacinski@...el.com>
> CC: Grzegorz Nitka <grzegorz.nitka@...el.com>
> CC: Michal Schmidt <mschmidt@...hat.com>
> CC: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
> CC: Michal Kubiak <michal.kubiak@...el.com>
> 
> v3:
>  - Add fixes tag (Michal K)

The fixes tag seems to have got lost in transit.

I believe it should be [1]:

Fixes: 0e2bddf9e5f9 ("ice: add ice_adapter for shared data across PFs on the same NIC")

[1] https://lore.kernel.org/intel-wired-lan/7f700a89-7058-4c16-b53a-2e84bbed8542@intel.com/

>  - add missing braces (lkp bot), turns out it's hard to purge C++ from your mind
>  - (no changes in the collision handling on 32bit systems)
> 
> v2:
> https://lore.kernel.org/intel-wired-lan/20250407112005.85468-1-przemyslaw.kitszel@intel.com/
>  - target to -net (Jiri)
>  - mix both halves of u64 DSN on 32bit systems (Jiri)
>  - (no changes in terms of fallbacks for pre-prod HW)
>  - warn when there is DSN collision after reducing to 32bit
> 
> v1:
> https://lore.kernel.org/netdev/20250306211159.3697-2-przemyslaw.kitszel@intel.com

...