netdev - Re: [PATCH v2 03/14] mfd: Add Microchip ZL3073x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b877823-a3d9-42bb-9b37-afc45180c404@lunn.ch>
Date: Thu, 10 Apr 2025 19:50:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ivan Vecera <ivecera@...hat.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Andy Shevchenko <andy@...nel.org>, netdev@...r.kernel.org,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
	Jiri Pirko <jiri@...nulli.us>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Prathosh Satish <Prathosh.Satish@...rochip.com>,
	Lee Jones <lee@...nel.org>, Kees Cook <kees@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Schmidt <mschmidt@...hat.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 03/14] mfd: Add Microchip ZL3073x support

On Thu, Apr 10, 2025 at 09:52:39AM +0200, Ivan Vecera wrote:
> 
> 
> On 10. 04. 25 9:19 dop., Krzysztof Kozlowski wrote:
> > On 09/04/2025 17:43, Andy Shevchenko wrote:
> > > > +/*
> > > > + * Regmap range configuration
> > > > + *
> > > > + * The device uses 7-bit addressing and has 16 register pages with
> > > > + * range 0x00-0x7f. The register 0x7f in each page acts as page
> > > > + * selector where bits 0-3 contains currently selected page.
> > > > + */
> > > > +static const struct regmap_range_cfg zl3073x_regmap_ranges[] = {
> > > > +	{
> > > > +		.range_min	= 0,
> > > 
> > > This still has the same issue, you haven't given a chance to me to reply
> > > in v1 thread. I'm not going to review this as it's not settled down yet.
> > > Let's first discuss the questions you have in v1.
> > > 
> 
> Sorry for that but I don't understand where the issue is... Many drivers
> uses this the same way.
> E.g.
> drivers/leds/leds-aw200xx.c
> drivers/mfd/rsmu_i2c.c
> sound/soc/codecs/tas2562.c
> ...and many others
> 
> All of them uses selector register that is present on all pages, wide range
> for register access <0, num_pages*window_size> and window <0, window_size>
> 
> Do they also do incorrectly or am I missing something?

The bigger point is, you should of asked this as part of the
discussion on the previous version. You should not post a new version
until all discussion has come to an end, you understand all the
comments, or you have persuaded the commentor that the code is in fact
correct.

Posting more versions without having that discussion just wastes
reviewers/Maintainers time, and that is not what you want to do if you
want to get your patch merged.

	Andrew