netdev - Re: [PATCH v2 net-next] eth: bnxt: add support rx side device memory TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYv5ecPX+k45W_0GJDGkojsx57g3bcfHk9FZVhD5UzgF=7sUQ@mail.gmail.com>
Date: Thu, 10 Apr 2025 16:39:41 -0700
From: Hongguang Gao <hongguang.gao@...adcom.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, andrew+netdev@...n.ch, horms@...nel.org, 
	michael.chan@...adcom.com, pavan.chebbi@...adcom.com, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, netdev@...r.kernel.org, dw@...idwei.uk, 
	kuniyu@...zon.com, sdf@...ichev.me, ahmed.zaki@...el.com, 
	aleksander.lobakin@...el.com, Mina Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH v2 net-next] eth: bnxt: add support rx side device memory TCP

On Thu, Apr 10, 2025 at 12:44 AM Taehee Yoo <ap420073@...il.com> wrote:

> Currently, bnxt_en driver satisfies the requirements of the Device
> memory TCP, which is HDS.
> So, it implements rx-side Device memory TCP for bnxt_en driver.
> It requires only converting the page API to netmem API.
> `struct page` of agg rings are changed to `netmem_ref netmem` and
> corresponding functions are changed to a variant of netmem API.
>
> It also passes PP_FLAG_ALLOW_UNREADABLE_NETMEM flag to a parameter of
> page_pool.
> The netmem will be activated only when a user requests devmem TCP.
>
> When netmem is activated, received data is unreadable and netmem is
> disabled, received data is readable.
> But drivers don't need to handle both cases because netmem core API will
> handle it properly.
> So, using proper netmem API is enough for drivers.
>
> Device memory TCP can be tested with
> tools/testing/selftests/drivers/net/hw/ncdevmem.
> This is tested with BCM57504-N425G and firmware version 232.0.155.8/pkg
> 232.1.132.8.
>
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> Tested-by: David Wei <dw@...idwei.uk>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> ---
>
> v2:
>  - Fix using wrong pointer in error path of bnxt_queue_mem_alloc().
>  - Fix compile warning due to a defined but unused variable.
>  - Do not define inline function in .c file.
>  - Remove unnecessary setting a pp.queue to 0.
>  - Add Tested-by tag from David Wei.
>  - Add Reviewed-by tag from Mina Almasry.
>

Hi Taehee,
v2 looks good to me.

Thanks,
-Hongguang

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5423 bytes)