netdev - Re: [PATCH net-next 1/2] net: txgbe: Support to set UDP tunnel port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/kdt3KkcSdzOSTn@localhost.localdomain>
Date: Fri, 11 Apr 2025 15:49:02 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
CC: <netdev@...r.kernel.org>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<horms@...nel.org>, <dlemoal@...nel.org>, <jdamato@...tly.com>,
	<saikrishnag@...vell.com>, <vadim.fedorenko@...ux.dev>,
	<przemyslaw.kitszel@...el.com>, <ecree.xilinx@...il.com>,
	<rmk+kernel@...linux.org.uk>, <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next 1/2] net: txgbe: Support to set UDP tunnel port

On Thu, Apr 10, 2025 at 03:44:55PM +0800, Jiawen Wu wrote:
> Tunnel types VXLAN/VXLAN_GPE/GENEVE are supported for txgbe devices. The
> hardware supports to set only one port for each tunnel type.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   | 113 ++++++++++++++++++
>  .../net/ethernet/wangxun/txgbe/txgbe_type.h   |   8 ++
>  2 files changed, 121 insertions(+)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h

[...]

> index 5937cbc6bd05..67ea81dfe786 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h
> @@ -88,6 +88,9 @@
>  /* Port cfg registers */
>  #define TXGBE_CFG_PORT_ST                       0x14404
>  #define TXGBE_CFG_PORT_ST_LINK_UP               BIT(0)
> +#define TXGBE_CFG_VXLAN                         0x14410
> +#define TXGBE_CFG_VXLAN_GPE                     0x14414
> +#define TXGBE_CFG_GENEVE                        0x14418
>  
>  /* I2C registers */
>  #define TXGBE_I2C_BASE                          0x14900
> @@ -359,6 +362,11 @@ struct txgbe {
>  	union txgbe_atr_input fdir_mask;
>  	int fdir_filter_count;
>  	spinlock_t fdir_perfect_lock; /* spinlock for FDIR */
> +
> +	/* tunnel port */
> +	__be16 vxlan_port;
> +	__be16 geneve_port;
> +	__be16 vxlan_gpe_port;

nitpick: Can these definitions be reordered to keep the consistent order in
         newly added code?
         (In all other places you have the order: VXLAN, GPE, GENEVE).

Thanks,
Michal

[...]