netdev - Re: [PATCH v4] net/mlx5: Fix null-ptr-deref in mlx5_create_{inner_,}ttc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1784cc08-918c-4745-bc7d-22a0217fea45@web.de>
Date: Fri, 11 Apr 2025 16:06:16 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Amir Tzin <amirtz@...dia.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Aya Levin <ayal@...dia.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH v4] net/mlx5: Fix null-ptr-deref in
 mlx5_create_{inner_,}ttc_table()

> Add NULL check for mlx5_get_flow_namespace() returns in
> mlx5_create_inner_ttc_table() and mlx5_create_ttc_table() to prevent
> NULL pointer dereference.

Can any other summary phrase variants become more desirable accordingly?

…
> ---
> V3 -> V4: Fix potential memory leak.

* Do you propose to complete the error handling for more function implementations?

* Please avoid duplicate source code.

* Can an other enumeration style become nicer for version numbers?

> V2 -> V3: No functional changes, just gathering the patches in a series.

Would you usually expect more than one update step then?

Regards,
Markus