netdev - [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411141023.14356-2-carnil@debian.org>
Date: Fri, 11 Apr 2025 16:10:24 +0200
From: Salvatore Bonaccorso <carnil@...ian.org>
To: Michal Kubecek <mkubecek@...e.cz>
Cc: netdev@...r.kernel.org,
	Salvatore Bonaccorso <carnil@...ian.org>,
	asciiwolf@...nam.cz,
	Petter Reinholdtsen <pere@...gry.com>
Subject: [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML

As pointed out in the Debian downstream report, as ethtool is a
command-line tool the XML root myst have the type property set to
console-application.

Additionally with the type propety set to desktop, ethtool is user
uninstallable via GUI (such as GNOME Software or KDE Discover).

Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
Reported-by: asciiwolf@...nam.cz
Cc: Petter Reinholdtsen <pere@...gry.com>
Link: https://bugs.debian.org/1102647
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
Signed-off-by: Salvatore Bonaccorso <carnil@...ian.org>
---
 org.kernel.software.network.ethtool.metainfo.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
index efe84c17e4cd..c31cae4bede6 100644
--- a/org.kernel.software.network.ethtool.metainfo.xml
+++ b/org.kernel.software.network.ethtool.metainfo.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
-- 
2.49.0