netdev - Re: [PATCH net-next v2] batman-adv: constify and move broadcast addr definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411151231.GI395307@horms.kernel.org>
Date: Fri, 11 Apr 2025 16:12:31 +0100
From: Simon Horman <horms@...nel.org>
To: Matthias Schiffer <mschiffer@...verse-factory.net>
Cc: Marek Lindner <marek.lindner@...lbox.org>,
	Simon Wunderlich <sw@...onwunderlich.de>,
	Antonio Quartulli <antonio@...delbit.com>,
	Sven Eckelmann <sven@...fation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] batman-adv: constify and move broadcast addr
 definition

On Wed, Apr 09, 2025 at 08:23:37PM +0200, Matthias Schiffer wrote:
> The variable is used only once and is read-only. Make it a const local
> variable.
> 
> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>
> ---
> 
> v2:
> - make variable static
> - remove "net: " subject prefix to match other batman-adv commits

Updated version looks good to me, thanks.

Reviewed-by: Simon Horman <horms@...nel.org>