netdev - [PATCH net 5/6] igc: cleanup PTP module if probe fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411162857.2754883-6-anthony.l.nguyen@intel.com>
Date: Fri, 11 Apr 2025 09:28:54 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: davem@...emloft.net,
	kuba@...nel.org,
	pabeni@...hat.com,
	edumazet@...gle.com,
	andrew+netdev@...n.ch,
	netdev@...r.kernel.org
Cc: Christopher S M Hall <christopher.s.hall@...el.com>,
	anthony.l.nguyen@...el.com,
	jacob.e.keller@...el.com,
	vinicius.gomes@...el.com,
	david.zage@...el.com,
	michal.swiatkowski@...ux.intel.com,
	richardcochran@...il.com,
	vinschen@...hat.com,
	rodrigo.cadore@...coustics.com,
	Mor Bar-Gabay <morx.bar.gabay@...el.com>
Subject: [PATCH net 5/6] igc: cleanup PTP module if probe fails

From: Christopher S M Hall <christopher.s.hall@...el.com>

Make sure that the PTP module is cleaned up if the igc_probe() fails by
calling igc_ptp_stop() on exit.

Fixes: d89f88419f99 ("igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller support")
Signed-off-by: Christopher S M Hall <christopher.s.hall@...el.com>
Reviewed-by: Corinna Vinschen <vinschen@...hat.com>
Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index f1330379e6bb..b1669d7cf435 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7231,6 +7231,7 @@ static int igc_probe(struct pci_dev *pdev,
 
 err_register:
 	igc_release_hw_control(adapter);
+	igc_ptp_stop(adapter);
 err_eeprom:
 	if (!igc_check_reset_block(hw))
 		igc_reset_phy(hw);
-- 
2.47.1