netdev - [PATCH v2 0/8] RDS bug fix collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411180207.450312-1-allison.henderson@oracle.com>
Date: Fri, 11 Apr 2025 11:01:59 -0700
From: allison.henderson@...cle.com
To: netdev@...r.kernel.org
Subject: [PATCH v2 0/8] RDS bug fix collection

From: Allison Henderson <allison.henderson@...cle.com>

Hi all,

This is v2 of the RDS bug fix collection set.

This set is a collection of bug fixes I've been working on porting from
uek rds to upstream rds.  We have some projects that are exploring the
idea of using upstream rds, but under enough stress, we've run into
dropped or out of sequence message bugs that we would like to fix.  We
have patches to address these, so I've ported them along with a handful
of other fixes they depend on.

Since v1, I've integrated the feed back from the last review, and have
since stabilized a few more patches that should be included as well.
Below is a summary of the changes:

net/rds: Avoid queuing superfluous send and recv work
   Removed

net/rds: Re-factor and avoid superfluous queuing of reconnect work
   Removed

net/rds: RDS/TCP does not initiate a connection
   Removed as a fix for "Re-factor and avoid superfluous queuing of reconnect work"

net/rds: rds_tcp_accept_one ought to not discard messages
   Fixed uninitialized inet found by kernel test robot
   Fixed smatch warning found by kernel test robot
   Moved kdoc for rds_transport into member specific comments.
   Added comment for the new conn_slots_available member

I've also included a few other bug fixes that I wanted to include in v1,
but still needed work at the time:
   net/rds: rds_tcp_conn_path_shutdown must not discard messages
   net/rds: Kick-start TCP receiver after accept

These last two needed some additional queue management patches to get
them through the selftests.  So those are included at the begining of
the set:
   net/rds: Add per cp work queue
   net/rds: Introduce a pool of worker threads for connection management
   net/rds: Re-factor queuing of shutdown work

So that's pretty much the break down of changes in this version.
Questions, comments, flames appreciated!
Thanks everybody!

Allison

Allison Henderson (1):
  net/rds: Add per cp work queue

Gerd Rausch (5):
  net/rds: No shortcut out of RDS_CONN_ERROR
  net/rds: rds_tcp_accept_one ought to not discard messages
  net/rds: Encode cp_index in TCP source port
  net/rds: rds_tcp_conn_path_shutdown must not discard messages
  net/rds: Kick-start TCP receiver after accept

Håkon Bugge (2):
  net/rds: Introduce a pool of worker threads for connection management
  net/rds: Re-factor queuing of shutdown work

 net/rds/connection.c  |  20 +++-
 net/rds/ib.c          |   5 +
 net/rds/ib_recv.c     |   2 +-
 net/rds/ib_send.c     |   2 +-
 net/rds/message.c     |   1 +
 net/rds/rds.h         |  74 +++++++++------
 net/rds/recv.c        |  11 +++
 net/rds/send.c        |  13 ++-
 net/rds/tcp.c         |  28 +++---
 net/rds/tcp.h         |  27 +++++-
 net/rds/tcp_connect.c |  68 ++++++++++++-
 net/rds/tcp_listen.c  | 216 +++++++++++++++++++++++++++++++-----------
 net/rds/tcp_recv.c    |   6 +-
 net/rds/tcp_send.c    |   4 +-
 net/rds/threads.c     |  40 ++++++--
 15 files changed, 395 insertions(+), 122 deletions(-)

-- 
2.43.0