netdev - Re: [PATCH net-next] io_uring/zcrx: enable tcp-data-split in selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410172850.55752f0b@kernel.org>
Date: Thu, 10 Apr 2025 17:28:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni
 <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>
Subject: Re: [PATCH net-next] io_uring/zcrx: enable tcp-data-split in
 selftest

On Wed, 9 Apr 2025 19:06:13 -0700 David Wei wrote:
> > You should really use defer() to register the "undo" actions
> > individually. Something like:
> > 
> >          ethtool(f"-G {cfg.ifname} tcp-data-split on", host=cfg.remote)
> >          defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
> >          ethtool(f"-G {cfg.ifname} rx 64", host=cfg.remote)
> >          defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
> >          ethtool(f"-X {cfg.ifname} equal {combined_chans - 1}", host=cfg.remote)
> >          defer(ethtool, f"-X {cfg.ifname} default", host=cfg.remote)
> >          ...
> > 
> > This patch is fine. But could you follow up and convert the test fully?  
> 
> I'll send a follow up, one to switch to defer(), then another to call
> tcp-data-split on.

Thinking again this should go to net, rather than net-next.
I'll apply it now, but just letting you know that the follow up needs
to wait a week for trees to converge.