netdev - Re: [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410200325.5621a4f5@kernel.org>
Date: Thu, 10 Apr 2025 20:03:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Donald Hunter <donald.hunter@...il.com>, Shuah Khan
 <shuah@...nel.org>, sd@...asysnail.net, ryazanov.s.a@...il.com, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, Xiao Liang
 <shaw.leon@...il.com>
Subject: Re: [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP
 interfaces

On Mon, 07 Apr 2025 21:46:12 +0200 Antonio Quartulli wrote:
> +	/* carrier for P2P interfaces is switched on and off when
> +	 * the peer is added or deleted.
> +	 *
> +	 * in case of P2MP interfaces we just keep the carrier always on
> +	 */
> +	if (ovpn->mode == OVPN_MODE_MP)
> +		netif_carrier_on(dev);

Any reason why you turn it during open rather than leaving it be before
registration? Now the link is down until first open, then it stays up
even if user closes?