netdev - Re: [Patch v4 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250410201341.17660e10@kernel.org>
Date: Thu, 10 Apr 2025 20:13:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joseph Huang <Joseph.Huang@...min.com>
Cc: <netdev@...r.kernel.org>, Joseph Huang <joseph.huang.2024@...il.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>, Roopa
 Prabhu <roopa@...dia.com>, Simon Horman <horms@...nel.org>,
 <linux-kernel@...r.kernel.org>, <bridge@...ts.linux.dev>
Subject: Re: [Patch v4 net-next 1/3] net: bridge: mcast: Add offload failed
 mdb flag

On Tue, 8 Apr 2025 11:41:09 -0400 Joseph Huang wrote:
> -	if (err)
> -		goto err;
> +	if (err == -EOPNOTSUPP)
> +		goto notsupp;
>  
>  	spin_lock_bh(&br->multicast_lock);
>  	mp = br_mdb_ip_get(br, &data->ip);
> @@ -516,11 +516,12 @@ static void br_switchdev_mdb_complete(struct net_device *dev, int err, void *pri
>  	     pp = &p->next) {
>  		if (p->key.port != port)
>  			continue;
> -		p->flags |= MDB_PG_FLAGS_OFFLOAD;
> +
> +		br_multicast_set_pg_offload_flags(p, !err);
>  	}
>  out:
>  	spin_unlock_bh(&br->multicast_lock);
> -err:
> +notsupp:

One small nit, please name the jump label after the target, 
not the reason for the jump. So here "out_free" would be 
a good name.

>  	kfree(priv);