netdev - Re: OA[PATCH v1 net-next 02/14] net: Add ops_undo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411033257.70991-1-kuniyu@amazon.com>
Date: Thu, 10 Apr 2025 20:32:49 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <lkp@...el.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<oe-kbuild-all@...ts.linux.dev>, <pabeni@...hat.com>
Subject: Re: OA[PATCH v1 net-next 02/14] net: Add ops_undo_single for module load/unload.

From: kernel test robot <lkp@...el.com>
Date: Fri, 11 Apr 2025 11:16:36 +0800
> Hi Kuniyuki,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on net-next/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/net-Factorise-setup_net-and-cleanup_net/20250410-102752
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20250410022004.8668-3-kuniyu%40amazon.com
> patch subject: [PATCH v1 net-next 02/14] net: Add ops_undo_single for module load/unload.
> config: loongarch-randconfig-001-20250411 (https://download.01.org/0day-ci/archive/20250411/202504111024.Qc5fW99d-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250411/202504111024.Qc5fW99d-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202504111024.Qc5fW99d-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    net/core/net_namespace.c: In function '__unregister_pernet_operations':
> >> net/core/net_namespace.c:1311:17: error: implicit declaration of function 'free_exit_list'; did you mean 'ops_exit_list'? [-Wimplicit-function-declaration]
>     1311 |                 free_exit_list(ops, &net_exit_list);
>          |                 ^~~~~~~~~~~~~~
>          |                 ops_exit_list

I missed one instance when CONFIG_NET_NS=n.
Will squash the diff below in v2.

---8<---
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 9ab3ba930d76..f7a99937645f 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -1326,8 +1326,9 @@ static void __unregister_pernet_operations(struct pernet_operations *ops)
 		list_del(&ops->list);
 	} else {
 		LIST_HEAD(net_exit_list);
+
 		list_add(&init_net.exit_list, &net_exit_list);
-		free_exit_list(ops, &net_exit_list);
+		ops_undo_single(ops, &net_exit_list);
 	}
 }
 
---8<---