netdev - Re: [PATCH v2] leds: trigger: netdev: Match net in netdev_trig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411074421.GV372032@google.com>
Date: Fri, 11 Apr 2025 08:44:21 +0100
From: Lee Jones <lee@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Tobias Junghans <tobias.junghans@...ub.de>,
	Andrew Lunn <andrew+netdev@...n.ch>, linux-leds@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] leds: trigger: netdev: Match net in
 netdev_trig_notify()

On Thu, 10 Apr 2025, Andrew Lunn wrote:

> On Thu, Apr 10, 2025 at 11:17:59AM +0100, Lee Jones wrote:
> > Andrew et al., please could you verify for sanity?
> 
> Sorry, i did not see this before.
> 
> Maybe we need a new MAINTAINER entry for
> drivers/leds/triggers/ledtrig-timer.c which points to the netdev list?

I assume you mean:

  drivers/leds/trigger/ledtrig-netdev.c

In which case, sure, I'm all for that.

Add it to your MAINTAINERS entry and I will Ack it.

> Humm:
> 
> ./scripts/get_maintainer.pl drivers/leds/trigger/ledtrig-netdev.c 
> Lee Jones <lee@...nel.org> (maintainer:LED SUBSYSTEM,commit_signer:4/4=100%)
> Pavel Machek <pavel@...nel.org> (maintainer:LED SUBSYSTEM)
> Andrew Lunn <andrew@...n.ch> (commit_signer:2/4=50%)
> Marek Vasut <marex@...x.de> (commit_signer:2/4=50%,authored:2/4=50%,added_lines:15/36=42%,removed_lines:3/8=38%)
> Heiner Kallweit <hkallweit1@...il.com> (commit_signer:1/4=25%,authored:1/4=25%,removed_lines:2/8=25%)
> Lukasz Majewski <lukma@...x.de> (commit_signer:1/4=25%,authored:1/4=25%,added_lines:21/36=58%,removed_lines:3/8=38%)
> linux-leds@...r.kernel.org (open list:LED SUBSYSTEM)
> linux-kernel@...r.kernel.org (open list)
> 
> So i should of been Cc:ed.

To be fair to the contributor, I don't always add commit signers either.

> Network names spaces and files in /sysfs probably need netdev
> involved, in order to get a good review.

Definitely.

-- 
Lee Jones [李琼斯]