netdev - Re: [PATCH net-next v2 0/6] xfrm & bonding: Correct use of xso.real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4b514e8a5bcbbe5dc1e6b6c9076b7a7afa57b45.camel@nvidia.com>
Date: Fri, 11 Apr 2025 07:46:15 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "razor@...ckwall.org" <razor@...ckwall.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
	"bbhushan2@...vell.com" <bbhushan2@...vell.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "hkelam@...vell.com" <hkelam@...vell.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "jv@...sburgh.net"
	<jv@...sburgh.net>, "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>, "liuhangbin@...il.com" <liuhangbin@...il.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, Leon Romanovsky <leonro@...dia.com>,
	"ayush.sawal@...lsio.com" <ayush.sawal@...lsio.com>, Jianbo Liu
	<jianbol@...dia.com>, "sbhatta@...vell.com" <sbhatta@...vell.com>,
	"horms@...nel.org" <horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
	"przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
	"steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
	"gakula@...vell.com" <gakula@...vell.com>, "sgoutham@...vell.com"
	<sgoutham@...vell.com>, "louis.peens@...igine.com"
	<louis.peens@...igine.com>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/6] xfrm & bonding: Correct use of
 xso.real_dev

On Thu, 2025-04-10 at 14:10 +0300, Nikolay Aleksandrov wrote:
> 
> Thank you for following up on this. It's definitely not getting
> cleaner with a bond
> ptr in xfrm protected by two locks in different drivers, but it
> should do AFAICT.
> In case there is another version I'd add a big comment of the locking
> expectations
> for real_dev, and maybe in the future it can fully move to the
> bonding as well.
> 
> For the set:
> Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>

Thanks for the review, I'll send v3 with the comment added.
I would have liked to push this a bit further with making real_dev
private, but I didn't find a way and that can be done separately.

Cosmin.