netdev - Re: [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sa65xjaromx.fsf@hjemme.reinholdtsen.name>
Date: Sat, 12 Apr 2025 06:26:46 +0200
From: Petter Reinholdtsen <pere@...gry.com>
To: netdev@...r.kernel.org
Cc: Daniel Rusek <asciiwolf@...nam.cz>, Salvatore Bonaccorso <carnil@...ian.org>, Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH ethtool] Set type property to console-application for
 provided AppStream metainfo XML


You are definitely on the right track, but the proposal from Daniel is
to include a binary provides too to fill a field wanted for
console-application components, ie:

diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
index efe84c1..7cfacf2 100644
--- a/org.kernel.software.network.ethtool.metainfo.xml
+++ b/org.kernel.software.network.ethtool.metainfo.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
@@ -11,6 +11,7 @@
   </description>
   <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
   <provides>
+    <binary>ethtool</binary>
     <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
   </provides>
 </component>

This look like a great proposal to me, and I have already tested the
change using 'appstreamcli validate-tree debian/ethtool' to check if
there are any issues with it.

The only minor information messages shown are these, which are not fatal
as far as I know:

  I: org.kernel.software.network.ethtool:6: summary-first-word-not-capitalized
  I: org.kernel.software.network.ethtool:~: content-rating-missing
  I: org.kernel.software.network.ethtool:~: developer-info-missing

-- 
Happy hacking
Petter Reinholdtsen