netdev - Re: [PATCH 1/3] net: qrtr: Turn QRTR into a bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250412115944.6528abcd@jic23-huawei>
Date: Sat, 12 Apr 2025 11:59:44 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Yassine Oudjana <y.oudjana@...tonmail.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Masahiro Yamada <masahiroy@...nel.org>, Nathan
 Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas.schier@...ux.dev>,
 Alexander Sverdlin <alexander.sverdlin@...il.com>, Sean Nyekjaer
 <sean@...nix.com>, Javier Carrasco <javier.carrasco.cruz@...il.com>, Matti
 Vaittinen <mazziesaccount@...il.com>, Antoniu Miclaus
 <antoniu.miclaus@...log.com>, Ramona Gradinariu
 <ramona.gradinariu@...log.com>, "Yo-Jung (Leo) Lin" <0xff07@...il.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Barnabás Czémán
 <barnabas.czeman@...nlining.org>, Danila Tikhonov <danila@...xyga.com>,
 Antoni Pokusinski <apokusinski01@...il.com>, Vasileios Amoiridis
 <vassilisamir@...il.com>, Petar Stoykov <pd.pstoykov@...il.com>, shuaijie
 wang <wangshuaijie@...nic.com>, Yasin Lee <yasin.lee.x@...il.com>,
 "Borislav Petkov (AMD)" <bp@...en8.de>, Dave Hansen
 <dave.hansen@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, Pawan Gupta
 <pawan.kumar.gupta@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 Yassine Oudjana <yassine.oudjana@...il.com>, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 netdev@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 1/3] net: qrtr: Turn QRTR into a bus

On Thu, 10 Apr 2025 12:44:25 +0000
Yassine Oudjana <y.oudjana@...tonmail.com> wrote:

> Missed one comment so sending a second reply.
> 
> On 06/04/2025 7:01 pm, Jonathan Cameron wrote:
> > On Sun, 06 Apr 2025 14:07:43 +0000
> > Yassine Oudjana <y.oudjana@...tonmail.com> wrote:
> >   
> >> Implement a QRTR bus to allow for creating drivers for individual QRTR
> >> services. With this in place, devices are dynamically registered for QRTR
> >> services as they become available, and drivers for these devices are
> >> matched using service and instance IDs.
> >>
> >> In smd.c, replace all current occurences of qdev with qsdev in order to
> >> distinguish between the newly added QRTR device which represents a QRTR
> >> service with the existing QRTR SMD device which represents the endpoint
> >> through which services are provided.
> >>
> >> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>  
> > Hi Yassine
> > 
> > Just took a quick look through.
> > 
> > It might make more sense to do this with an auxiliary_bus rather
> > than defining a new bus.  
> 
> I'm not familiar with auxiliary bus, but reading the documentation it 
> seems to me like it's used like MFD where there is a device that has 
> multiple functions, just without the subdevices having physical 
> addresses. QRTR is not really a device but more closely resembles 
> something like PCI or I2C as a communication interface.

Fair enough. If this has real bus like properties then it may make
sense to go with a new explicit bus.

Jonathan