netdev - Re: [PATCH net-next] net: ngbe: fix memory leak in ngbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411183212.51b084af@kernel.org>
Date: Fri, 11 Apr 2025 18:32:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Abdun Nihaal <abdun.nihaal@...il.com>
Cc: Markus Elfring <Markus.Elfring@....de>, netdev@...r.kernel.org, LKML
 <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Edward Cree <ecree.xilinx@...il.com>,
 Eric Dumazet <edumazet@...gle.com>, Jiawen Wu <jiawenwu@...stnetic.com>,
 Mengyuan Lou <mengyuanlou@...-swift.com>, Paolo Abeni <pabeni@...hat.com>,
 Sai Krishna <saikrishnag@...vell.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] net: ngbe: fix memory leak in ngbe_probe()
 error path

On Fri, 11 Apr 2025 10:44:55 +0530 Abdun Nihaal wrote:
> Hello Markus,
> 
> On Wed, Apr 09, 2025 at 05:23:39PM +0200, Markus Elfring wrote:
> > How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc1#n145  
> 
> Thanks for pointing that out. Actually I wasn't sure about which commit
> to add as the Fixes tag, so I left it assuming that the maintainers
> would know better.
> 
> I was confused between the following two commits both of which change
> the kfree(wx->mac_table) line.
> - 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")
> - 9607a3e62645 ("net: wangxun: Rename private structure in libwx")

I think:

Fixes: 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")

rss_key gets allocated at that point but never freed. The later patches
just move it around and fix up a little but first broken patch counts.