netdev - Re: [PATCH] net: use %ld format specifier for PTR_ERR in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_uYSmMDHE_vpFcQ@qasdev.system>
Date: Sun, 13 Apr 2025 11:56:10 +0100
From: Qasim Ijaz <qasdev00@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: jlayton@...nel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, nathan@...nel.org
Subject: Re: [PATCH] net: use %ld format specifier for PTR_ERR in pr_warn

On Sat, Apr 12, 2025 at 04:28:38PM -0700, Kuniyuki Iwashima wrote:
> From: Qasim Ijaz <qasdev00@...il.com>
> Date: Sat, 12 Apr 2025 23:55:28 +0100
> > PTR_ERR yields type long, so use %ld format specifier in pr_warn.
> 
> errno fits in the range of int, so no need to use %ld.
> 
> 
> > 
> > Fixes: 193510c95215 ("net: add debugfs files for showing netns refcount tracking info")
> 
> The series is not yet applied.  It's not necessary this time, but
> in such a case, please reply to the original patch thread.
> 
> Also, please make sure your patch can be applied cleanly on the latest
> remote net-next.git and the Fixes tag points to an existing commit.
> 
Hi Kuniyuki

Thank you for your comments, as Nathan said the current code emits a
compiler warning as per the kernel test robot. 

Given this would you like me to resend patch v2 with the changes you and
Nathan specified?

Regards,
Qasim
> 
> > Signed-off-by: Qasim Ijaz <qasdev00@...il.com> 
> > ---
> >  net/core/net_namespace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> > index f47b9f10af24..a419a3aa57a6 100644
> > --- a/net/core/net_namespace.c
> > +++ b/net/core/net_namespace.c
> > @@ -1652,7 +1652,7 @@ static int __init ns_debug_init(void)
> >  	if (ref_tracker_debug_dir) {
> >  		ns_ref_tracker_dir = debugfs_create_dir("net_ns", ref_tracker_debug_dir);
> >  		if (IS_ERR(ns_ref_tracker_dir)) {
> > -			pr_warn("net: unable to create ref_tracker/net_ns directory: %d\n",
> > +			pr_warn("net: unable to create ref_tracker/net_ns directory: %ld\n",
> >  				PTR_ERR(ns_ref_tracker_dir));
> >  			goto out;
> >  		}
> > -- 
> > 2.39.5