netdev - Re: [PATCH net-next 4/4] net: stmmac: qcom-ethqos: remove speed_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9987dc3b-8ec4-4c13-8054-73b2b52020e5@lunn.ch>
Date: Sun, 13 Apr 2025 23:07:49 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH net-next 4/4] net: stmmac: qcom-ethqos: remove
 speed_mode_2500() method

On Sat, Apr 12, 2025 at 03:10:04PM +0100, Russell King (Oracle) wrote:
> qcom-ethqos doesn't need to implement the speed_mode_2500() method as
> it is only setting priv->plat->phy_interface to 2500BASE-X, which is
> already a pre-condition for assigning speed_mode_2500 in
> qcom_ethqos_probe(). So, qcom_ethqos_speed_mode_2500() has no effect.
> Remove it.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew