netdev - Re: [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <963c2166-aed8-4928-bdeb-6acbec2b0ea7@openvpn.net>
Date: Mon, 14 Apr 2025 15:39:50 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>, Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, ryazanov.s.a@...il.com,
 Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Xiao Liang <shaw.leon@...il.com>, steffen.klassert@...unet.com,
 antony.antony@...unet.com
Subject: Re: [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel
 Offload (ovpn)

On 11/04/2025 23:18, Jakub Kicinski wrote:
> On Fri, 11 Apr 2025 15:50:49 +0200 Sabrina Dubroca wrote:
>>> My understanding is that this is the standard approach to:
>>> 1) hook in the middle of registration/deregistration;
>>> 2) handle events generated by other components/routines.
>>>
>>> I see in /drivers/net/ almost every driver registers a notifier for their
>>> own device.
>>
>> I think most of them register a notifier for their lower device
>> (bridge port, real device under a vlan, or similar).
>>
>> I've mentioned at some point that it would be more usual to replace
>> this notifier with a custom dellink, and that ovpn->registered could
>> likely be replaced with checking for NETREG_REGISTERED. I just thought
>> it could be cleaned up a bit later, but it seems Jakub wants it done
>> before taking the patches :)
> 
> Ideally, yes. One fewer place for us to check when trying to figure
> out if we will break anything with the locking changes :(
> Notifiers are very powerful but that comes at high maintenance cost.

ACK, working on it!

Thanks,

-- 
Antonio Quartulli
OpenVPN Inc.