netdev - Re: [PATCH net-next 11/15] ice: make const read-only array dflt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d62e6b6-0535-4157-b742-d6a608b776ab@collabora.com>
Date: Mon, 14 Apr 2025 09:38:36 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org
Cc: Colin Ian King <colin.i.king@...il.com>, przemyslaw.kitszel@...el.com,
 kernel-janitors@...r.kernel.org, Rinitha S <sx.rinitha@...el.com>
Subject: Re: [PATCH net-next 11/15] ice: make const read-only array dflt_rules
 static

On 4/12/25 1:43 AM, Tony Nguyen wrote:
> From: Colin Ian King <colin.i.king@...il.com>
> 
> Don't populate the const read-only array dflt_rules on the stack at run
> time, instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> index 1d118171de37..aceec184e89b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> @@ -1605,7 +1605,7 @@ void ice_fdir_replay_fltrs(struct ice_pf *pf)
>   */
>  int ice_fdir_create_dflt_rules(struct ice_pf *pf)
>  {
> -	const enum ice_fltr_ptype dflt_rules[] = {
> +	static const enum ice_fltr_ptype dflt_rules[] = {
>  		ICE_FLTR_PTYPE_NONF_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_UDP,
>  		ICE_FLTR_PTYPE_NONF_IPV6_TCP, ICE_FLTR_PTYPE_NONF_IPV6_UDP,
>  	};


-- 
Regards,
Usama