netdev - Re: [PATCH RFC net-next 3/5] net: phy: add Marvell PHY PTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_05bl9ykY9UzCEI@shell.armlinux.org.uk>
Date: Mon, 14 Apr 2025 17:35:58 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH RFC net-next 3/5] net: phy: add Marvell PHY PTP support

On Mon, Apr 14, 2025 at 06:16:43PM +0200, Kory Maincent wrote:
> On Mon, 14 Apr 2025 17:21:37 +0200
> Kory Maincent <kory.maincent@...tlin.com> wrote:
> 
> > On Mon, 14 Apr 2025 15:55:09 +0100
> > "Russell King (Oracle)" <linux@...linux.org.uk> wrote:
> > 
> > > On Mon, Apr 14, 2025 at 04:43:14PM +0200, Kory Maincent wrote:  
> > > > On Fri, 11 Apr 2025 22:26:42 +0100
> > > > Russell King <rmk+kernel@...linux.org.uk> wrote:
> > > >     
> >  [...]  
> > > > 
> > > > It seems a lot less stable than the first version of the driver.
> 
> FYI there is also an invalid wait context error:
> [   65.041285] =============================
> [   65.045286] [ BUG: Invalid wait context ]
> [   65.049289] 6.14.0-13314-g04846c13cbec-dirty #91 Not tainted
> [   65.054938] -----------------------------
> [   65.058939] swapper/0/0 is trying to lock:
> [   65.063028] ffff000805b0c110 (&rxq->rx_mutex){....}-{4:4}, at:
> marvell_ptp_rxtstamp+0xf0/0x228 
> [   65.071665] other info that might help us debug this: 
> [   65.076707] context-{3:3}
> [   65.079320] no locks held by swapper/0/0.
> [   65.083321] stack backtrace:
> [   65.086198] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted
> 6.14.0-13314-g04846c13cbec-dirty #91 PREEMPT(voluntary)
> [   65.086207] Hardware name: Fluyt Prototype 1 Carrier Board ZU9 mpsoc  (DT)
> [   65.086211] Call trace: 
> [   65.086214]  show_stack+0x18/0x24 (C)
> [   65.086224]  dump_stack_lvl+0xa4/0xf4
> [   65.086233]  dump_stack+0x18/0x24
> [   65.086240]  __lock_acquire+0xa14/0x2000
> [   65.086250]  lock_acquire+0x1c4/0x360
> [   65.086259]  __mutex_lock+0xa0/0x52c
> [   65.086266]  mutex_lock_nested+0x24/0x30
> [   65.086273]  marvell_ptp_rxtstamp+0xf0/0x228
> [   65.086282]  marvell_phy_ptp_rxtstamp+0x18/0x24
> [   65.086290]  skb_defer_rx_timestamp+0x104/0x31c

Hmm, I guess that mutex needs to be a spinlock then.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!