netdev - Re: [PATCH net-next] octeon_ep_vf: Remove octep_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_0_AyjQRT58dYIb@gallifrey>
Date: Mon, 14 Apr 2025 16:59:47 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shinas Rasheed <srasheed@...vell.com>,
	Veerasenareddy Burru <vburru@...vell.com>,
	Sathesh Edara <sedara@...vell.com>,
	Satananda Burla <sburla@...vell.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] octeon_ep_vf: Remove octep_vf_wq

* Simon Horman (horms@...nel.org) wrote:
> commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device
> initialization") added octep_vf_wq but it has never been used. Remove it.
> 
> Reported-by: Dr. David Alan Gilbert <linux@...blig.org>
> Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/
> Signed-off-by: Simon Horman <horms@...nel.org>

Thanks,

Reviewed-by: Dr. David Alan Gilbert <linux@...blig.org>

> ---
>  drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 --
>  drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> index 18c922dd5fc6..5841e30dff2a 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> @@ -18,8 +18,6 @@
>  #include "octep_vf_config.h"
>  #include "octep_vf_main.h"
>  
> -struct workqueue_struct *octep_vf_wq;
> -
>  /* Supported Devices */
>  static const struct pci_device_id octep_vf_pci_id_tbl[] = {
>  	{PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)},
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> index 1a352f41f823..b9f13506f462 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
> @@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct)
>  #define octep_vf_read_csr64(octep_vf_dev, reg_off)         \
>  	readq((octep_vf_dev)->mmio.hw_addr + (reg_off))
>  
> -extern struct workqueue_struct *octep_vf_wq;
> -
>  int octep_vf_device_setup(struct octep_vf_device *oct);
>  int octep_vf_setup_iqs(struct octep_vf_device *oct);
>  void octep_vf_free_iqs(struct octep_vf_device *oct);
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/