netdev - Re: [PATCH net-next] tc: Return an error if filters try to attach too many actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250414142416.7a4936d2@kernel.org>
Date: Mon, 14 Apr 2025 14:24:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: Toke Høiland-Jørgensen <toke@...hat.com>, Jamal
 Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tc: Return an error if filters try to attach
 too many actions

On Mon, 14 Apr 2025 14:03:31 -0700 Cong Wang wrote:
> > > I wonder ENOSPC is a better errno than EINVAL here?  
> > 
> > I think EINVAL is fine, it's the generic "netlink says no" error code. 
> > The string error should be clear enough.  
> 
> IMHO, EINVAL is abused (which is probably why we introduced extack). I
> prefer to find a better errno than EINVAL whenever possible.
>  
> Extack is available but it is mostly for human to read, not technically
> an API for programs to interpret.

How is user space going to interpret the error code here?
Seems to me that'd mean the user space is both aware of the limit 
and yet trying to send more actions.