netdev - [PATCH net 0/5] Collection of DSA bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250414212708.2948164-1-vladimir.oltean@nxp.com>
Date: Tue, 15 Apr 2025 00:27:08 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>,
	Russell King <linux@...linux.org.uk>,
	Tobias Waldekranz <tobias@...dekranz.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Vivien Didelot <vivien.didelot@...il.com>
Subject: [PATCH net 0/5] Collection of DSA bug fixes

Prompted by Russell King's 3 DSA bug reports from Friday (linked in
their respective patches: 1, 2 and 3), I am providing fixes to those, as
well as flushing the queue with 2 other bug fixes I had.

1: fix NULL pointer dereference during mv88e6xxx driver unbind, on old
   switch models which lack PVT and/or STU. Seen on the ZII dev board
   rev B.
2: fix failure to delete bridge port VLANs on old mv88e6xxx chips which
   lack STU. Seen on the same board.
3: fix WARN_ON() and resource leak in DSA core on driver unbind. Seen on
   the same board but is a much more widespread issue.
4: fix use-after-free during probing of DSA trees with >= 3 switches,
   if -EPROBE_DEFER exists. In principle issue also exists for the ZII
   board, I reproduced on Turris MOX.
5: fix incorrect use of refcount API in DSA core for those switches
   which use tag_8021q (felix, sja1105, vsc73xx). Returning an error
   when attempting to delete a tag_8021q VLAN prints a WARN_ON(), which
   is harmless but might be problematic with CONFIG_PANIC_ON_OOPS.

Vladimir Oltean (5):
  net: dsa: mv88e6xxx: avoid unregistering devlink regions which were
    never registered
  net: dsa: mv88e6xxx: fix -ENOENT when deleting VLANs and MST is
    unsupported
  net: dsa: clean up FDB, MDB, VLAN entries on unbind
  net: dsa: free routing table on probe failure
  net: dsa: avoid refcount warnings when ds->ops->tag_8021q_vlan_del()
    fails

 drivers/net/dsa/mv88e6xxx/chip.c    | 13 ++++++-
 drivers/net/dsa/mv88e6xxx/devlink.c |  3 +-
 net/dsa/dsa.c                       | 59 ++++++++++++++++++++++++-----
 net/dsa/tag_8021q.c                 |  2 +-
 4 files changed, 64 insertions(+), 13 deletions(-)

-- 
2.43.0