netdev - Re: [PATCH 4/4] net: register debugfs file for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <782ca402-83a0-4a7b-b29b-ac021932d081@lunn.ch>
Date: Tue, 15 Apr 2025 01:16:11 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: jlayton@...nel.org, akpm@...ux-foundation.org, davem@...emloft.net,
	edumazet@...gle.com, horms@...nel.org, kuba@...nel.org,
	linux-kernel@...r.kernel.org, nathan@...nel.org,
	netdev@...r.kernel.org, pabeni@...hat.com, qasdev00@...il.com
Subject: Re: [PATCH 4/4] net: register debugfs file for net_device refcnt
 tracker

On Mon, Apr 14, 2025 at 03:27:36PM -0700, Kuniyuki Iwashima wrote:
> From: Jeff Layton <jlayton@...nel.org>
> Date: Mon, 14 Apr 2025 10:45:49 -0400
> > As a nearly-final step in register_netdevice(), finalize the name in the
> > refcount tracker, and register a debugfs file for it.
> > 
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> >  net/core/dev.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index 2f7f5fd9ffec7c0fc219eb6ba57d57a55134186e..db9cac702bb2230ca2bbc2c04ac0a77482c65fc3 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -10994,6 +10994,8 @@ int register_netdevice(struct net_device *dev)
> >  	    dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
> >  		rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U, GFP_KERNEL, 0, NULL);
> >  
> > +	/* Register debugfs file for the refcount tracker */
> > +	ref_tracker_dir_debugfs(&dev->refcnt_tracker, dev->name);
> 
> dev->name is not unique across network namespaces, so we should specify
> a netns-specific parent dir here.
> 
> For example, syzkaller creates a bunch of devices with the same name in
> different network namespaces.
> 
> Then, we also need to move the file when dev is moved to another netns
> in __dev_change_net_namespace().

The address of dev should be unique, and does not change as the netdev
moves between network name spaces. So you could postfix it with the
hashed version of an address, as produced by %pK. This is debugfs, it
does not need to be too friendly.

       Andrew