netdev - Re: [PATCH net-next v10 10/14] xsc: Add eth needed qp and cq apis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250414184510.367bbcaf@kernel.org>
Date: Mon, 14 Apr 2025 18:45:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Xin Tian" <tianx@...silicon.com>
Cc: <netdev@...r.kernel.org>, <leon@...nel.org>, <andrew+netdev@...n.ch>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>,
 <jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>,
 <weihg@...silicon.com>, <wanry@...silicon.com>, <jacky@...silicon.com>,
 <horms@...nel.org>, <parthiban.veerasooran@...rochip.com>,
 <masahiroy@...nel.org>, <kalesh-anakkur.purayil@...adcom.com>,
 <geert+renesas@...der.be>, <geert@...ux-m68k.org>
Subject: Re: [PATCH net-next v10 10/14] xsc: Add eth needed qp and cq apis

On Fri, 11 Apr 2025 14:53:17 +0800 Xin Tian wrote:
> +	netdev = ((struct xsc_adapter *)xdev->eth_priv)->netdev;

This double cast is a bit ugly, and it repeats 7 times in the initial
submission. Please add a helper somewhere, along the lines of:

static inline xsc_dev_to_netdev(struct xsc_core_device *xdev)
{
	return ((struct xsc_adapter *)xdev->eth_priv)->netdev;
}