netdev - Re: [PATCH net-next v2] netdev: fix the locking for netdev notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250415075300.5c5fcb76@kernel.org>
Date: Tue, 15 Apr 2025 07:53:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, syzkaller
 <syzkaller@...glegroups.com>, Kuniyuki Iwashima <kuniyu@...zon.com>,
 sdf@...ichev.me, jdamato@...tly.com, almasrymina@...gle.com
Subject: Re: [PATCH net-next v2] netdev: fix the locking for netdev
 notifications

On Mon, 14 Apr 2025 18:11:14 -0700 Stanislav Fomichev wrote:
> > +static inline void netdev_lock_ops_to_full(struct net_device *dev)
> > +{
> > +	if (!netdev_need_ops_lock(dev))
> > +		netdev_lock(dev);  
> 
> Optional nit: I'm getting lost in all the helpers, I'd add the following here:
> 
> else
> 	netdev_ops_assert_locked(dev);
> 
> Or maybe even:
> 
> if (netdev_need_ops_lock)
> 	netdev_ops_assert_locked
> else
> 	netdev_lock
> 
> To express the constraints better.

Hm, yes, I like.