netdev - Re: [PATCH net 0/8] ynl: avoid leaks in attr override and spec fixes for C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bcdf54d-a744-4f51-9fdb-7121099538b0@intel.com>
Date: Tue, 15 Apr 2025 10:39:32 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <donald.hunter@...il.com>, <netdev@...r.kernel.org>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<horms@...nel.org>, <daniel@...earbox.net>, <sdf@...ichev.me>
Subject: Re: [PATCH net 0/8] ynl: avoid leaks in attr override and spec fixes
 for C



On 4/14/2025 2:18 PM, Jakub Kicinski wrote:
> The C rt-link work revealed more problems in existing codegen
> and classic netlink specs.
> 
> Patches 1 - 4 fix issues with the codegen. Patches 1 and 2 are
> pre-requisites for patch 3. Patch 3 fixes leaking memory if user
> tries to override already set attr. Patch 4 validates attrs in case
> kernel sends something we don't expect.
> 
> Remaining patches fix and align the specs. Patch 5 changes nesting,
> the rest are naming adjustments.
> 
> Jakub Kicinski (8):
>   tools: ynl-gen: don't declare loop iterator in place
>   tools: ynl-gen: move local vars after the opening bracket
>   tools: ynl-gen: individually free previous values on double set
>   tools: ynl-gen: make sure we validate subtype of array-nest
>   netlink: specs: rt-link: add an attr layer around alt-ifname
>   netlink: specs: rtnetlink: attribute naming corrections
>   netlink: specs: rt-link: adjust mctp attribute naming
>   netlink: specs: rt-neigh: prefix struct nfmsg members with ndm
> 

For the series:

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  Documentation/netlink/specs/rt_link.yaml  | 20 +++--
>  Documentation/netlink/specs/rt_neigh.yaml | 14 ++--
>  tools/net/ynl/pyynl/ynl_gen_c.py          | 96 +++++++++++++++++------
>  3 files changed, 92 insertions(+), 38 deletions(-)
>