netdev - Re: [PATCH net v2] net: lwtunnel: disable BHs when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+podS1f4taEg3tFdpp3qDEKmSs5XAU7S+u8-ztMMp=wA@mail.gmail.com>
Date: Tue, 15 Apr 2025 11:17:04 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Justin Iurman <justin.iurman@...ege.be>
Cc: Network Development <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Eduard Zingerman <eddyz87@...il.com>, bpf <bpf@...r.kernel.org>, 
	Stanislav Fomichev <stfomichev@...il.com>, Sebastian Sewior <bigeasy@...utronix.de>, 
	Andrea Mayer <andrea.mayer@...roma2.it>, Stefano Salsano <stefano.salsano@...roma2.it>, 
	Paolo Lungaroni <paolo.lungaroni@...roma2.it>
Subject: Re: [PATCH net v2] net: lwtunnel: disable BHs when required

On Tue, Apr 15, 2025 at 10:33 AM Justin Iurman <justin.iurman@...ege.be> wrote:
>                 goto drop;
>         }
> -       lwtstate = dst->lwtstate;
>
> +       lwtstate = dst->lwtstate;
>         if (lwtstate->type == LWTUNNEL_ENCAP_NONE ||
>             lwtstate->type > LWTUNNEL_ENCAP_MAX)
>                 return 0;
> @@ -460,10 +469,8 @@ int lwtunnel_input(struct sk_buff *skb)
>                 goto drop;
>
>         return ret;
> -
>  drop:
>         kfree_skb(skb);
> -

Don't see the point of seemingly random cleanups, but overall lgtm.