netdev - Re: [PATCH iwl-net v4] ice: use DSN instead of PCI BDF for ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250415194642.GH395307@horms.kernel.org>
Date: Tue, 15 Apr 2025 20:46:42 +0100
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
	Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
	Jacob Keller <jacob.e.keller@...el.com>,
	Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>,
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
	Karol Kolacinski <karol.kolacinski@...el.com>,
	Grzegorz Nitka <grzegorz.nitka@...el.com>,
	Michal Schmidt <mschmidt@...hat.com>,
	Sergey Temerkhanov <sergey.temerkhanov@...el.com>,
	Michal Kubiak <michal.kubiak@...el.com>
Subject: Re: [PATCH iwl-net v4] ice: use DSN instead of PCI BDF for
 ice_adapter index

On Mon, Apr 14, 2025 at 03:12:41PM +0200, Przemek Kitszel wrote:
> Use Device Serial Number instead of PCI bus/device/function for
> the index of struct ice_adapter.
> 
> Functions on the same physical device should point to the very same
> ice_adapter instance, but with two PFs, when at least one of them is
> PCI-e passed-through to a VM, it is no longer the case - PFs will get
> seemingly random PCI BDF values, and thus indices, what finally leds to
> each of them being on their own instance of ice_adapter. That causes them
> to don't attempt any synchronization of the PTP HW clock usage, or any
> other future resources.
> 
> DSN works nicely in place of the index, as it is "immutable" in terms of
> virtualization.
> 
> Fixes: 0e2bddf9e5f9 ("ice: add ice_adapter for shared data across PFs on the same NIC")
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Suggested-by: Jiri Pirko <jiri@...nulli.us>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> CC: Karol Kolacinski <karol.kolacinski@...el.com>
> CC: Grzegorz Nitka <grzegorz.nitka@...el.com>
> CC: Michal Schmidt <mschmidt@...hat.com>
> CC: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
> CC: Michal Kubiak <michal.kubiak@...el.com>
> CC: Simon Horman <horms@...nel.org>
> 
> v4:
>  - Add fixes tag for real... (Simon)
>  - extend commit message (Simon)
>  - pass dsn to ice_adapter_new() to have simpler code
>    (I happened to do that as (local) followup) (me)

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>