netdev - Re: [PATCH v2 2/8] net/rds: Introduce a pool of worker threads for connection management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a1d5c373c1443b71ab398c618f9ba4eaca60e44.camel@oracle.com>
Date: Tue, 15 Apr 2025 21:33:51 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 2/8] net/rds: Introduce a pool of worker threads for
 connection management

On Mon, 2025-04-14 at 17:46 -0700, Jakub Kicinski wrote:
> On Fri, 11 Apr 2025 11:02:01 -0700 allison.henderson@...cle.com wrote:
> > RDS uses a single threaded work queue for connection management. This
> > involves creation and deletion of QPs and CQs. On certain HCAs, such
> > as CX-3, these operations are para-virtualized and some part of the
> > work has to be conducted by the Physical Function (PF) driver.
> > 
> > In fail-over and fail-back situations, there might be 1000s of
> > connections to tear down and re-establish. Hence, expand the number
> > work queues.
> 
> sparse warnings here (C=1):
> 
> net/rds/connection.c:174:55: warning: incorrect type in argument 1 (different base types)
> net/rds/connection.c:174:55:    expected unsigned int [usertype] a
> net/rds/connection.c:174:55:    got restricted __be32 const
> net/rds/connection.c:175:55: warning: incorrect type in argument 2 (different base types)
> net/rds/connection.c:175:55:    expected unsigned int [usertype] b
> net/rds/connection.c:175:55:    got restricted __be32 const

Alrighty, will fix these.  Thanks for the catch!

Allison