netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix Get Tx Topology AQ command error on E830

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5911A2EE3BCA642A7C629822BAB22@MW4PR11MB5911.namprd11.prod.outlook.com>
Date: Tue, 15 Apr 2025 06:00:20 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Greenwalt, Paul" <paul.greenwalt@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix Get Tx Topology AQ
 command error on E830


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Thursday, February 20, 2025 11:27 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>; intel-wired-lan@...ts.osuosl.org;
> netdev@...r.kernel.org; Greenwalt, Paul <paul.greenwalt@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix Get Tx Topology AQ
> command error on E830
> 
> On Thu, Feb 20, 2025 at 03:15:24PM -0800, Jacob Keller wrote:
> > From: Paul Greenwalt <paul.greenwalt@...el.com>
> >
> > The Get Tx Topology AQ command (opcode 0x0418) has different read flag
> > requriements depending on the hardware/firmware. For E810, E822, and
> E823
> > firmware the read flag must be set, and for newer hardware (E825 and
> E830)
> > it must not be set.
> >
> > This results in failure to configure Tx topology and the following warning
> > message during probe:
> >
> >   DDP package does not support Tx scheduling layers switching feature -
> >   please update to the latest DDP package and try again
> >
> > The current implementation only handles E825-C but not E830. It is
> > confusing as we first check ice_is_e825c() and then set the flag in the set
> > case. Finally, we check ice_is_e825c() again and set the flag for all other
> > hardware in both the set and get case.
> >
> > Instead, notice that we always need the read flag for set, but only need
> > the read flag for get on E810, E822, and E823 firmware. Fix the logic to
> > check the MAC type and set the read flag in get only on the older devices
> > which require it.
> >
> > Fixes: ba1124f58afd ("ice: Add E830 device IDs, MAC type and registers")
> > Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> > ---
> > Changes in v2:
> > - Update commit message to include the warning users see
> > - Rework code to set the flag for E810 and E822 instead of to *not* set it
> >   for E825-C and E830. We anticipate that future hardware and firmware
> >   versions will behave like E830.
> > - Link to v1: https://lore.kernel.org/r/20250218-jk-e830-ddp-loading-fix-
> v1-1-47dc8e8d4ab5@...el.com
> > ---
> >  drivers/net/ethernet/intel/ice/ice_ddp.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c
> b/drivers/net/ethernet/intel/ice/ice_ddp.c
> > index
> 03988be03729b76e96188864896527060c8c4d5b..59323c019544fc1f75dc
> b8a5d31e0b0c82932fe1 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_ddp.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_ddp.c

Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>