netdev - Re: [PATCH v13 00/22] Type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f1ac76d-1b69-4517-8b13-0fc46e1ff948@amd.com>
Date: Tue, 15 Apr 2025 08:09:05 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Alison Schofield <alison.schofield@...el.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, dave.jiang@...el.com
Subject: Re: [PATCH v13 00/22] Type2 device basic support

Hi Allison,


I forgot to fix the problem you reported in v12.


I rebuild everything patch by patch in each new version ... but your 
comments on the cover letter, which I agree it is the right place to 
complain, correlates with none, and I just missed it.


Apologies. I'll fix it in v14 ...


On 4/14/25 22:21, Alison Schofield wrote:
> On Mon, Apr 14, 2025 at 04:13:14PM +0100, alejandro.lucero-palau@....com wrote:
>> From: Alejandro Lucero <alucerop@....com>
>
> Not able to make the cxl test module.
>
> test/mem.c: In function ‘cxl_mock_mem_probe’:
> linux/include/linux/stddef.h:8:14: warning: passing argument 3 of ‘cxl_memdev_state_create’ makes integer from pointer without a cast [-Wint-conversion]
>      8 | #define NULL ((void *)0)
>        |              ^~~~~~~~~~~
>        |              |
>        |              void *
> test/mem.c:1720:58: note: in expansion of macro ‘NULL’
>   1720 |         mds = cxl_memdev_state_create(dev, pdev->id + 1, NULL);
>        |                                                          ^~~~
> In file included from test/mem.c:14:
> linux/drivers/cxl/cxlmem.h:742:54: note: expected ‘u16’ {aka ‘short unsigned int’} but argument is of type ‘void *’
>    742 |                                                  u16 dvsec);
>        |                                                  ~~~~^~~~~
> test/mem.c:1721:15: error: too few arguments to function ‘cxl_memdev_state_create’
>   1721 |         mds = cxl_memdev_state_create(dev);
>        |               ^~~~~~~~~~~~~~~~~~~~~~~
> linux/drivers/cxl/cxlmem.h:741:26: note: declared here
>    741 | struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev, u64 serial,
>        |                          ^~~~~~~~~~~~~~~~~~~~~~~
>
>
> snip