netdev - Re: [PATCH v2 net-next 02/14] net: Add ops_undo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250414171205.703b743b@kernel.org>
Date: Mon, 14 Apr 2025 17:12:05 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 02/14] net: Add ops_undo_single for module
 load/unload.

On Mon, 14 Apr 2025 17:01:48 -0700 Jakub Kicinski wrote:
> On Fri, 11 Apr 2025 13:52:31 -0700 Kuniyuki Iwashima wrote:
> > +	bool hold_rtnl = !!ops->exit_batch_rtnl;
> > +
> > +	list_add(&ops->list, &ops_list);
> > +	ops_undo_list(&ops_list, NULL, net_exit_list, false, hold_rtnl);  
> 
> Is this the only reason for the hold_rtnl argument to ops_undo_list() ?
> We walk the ops once for pre-exit, before calling rtnl batch.
> As we walk them we can |= their exit_batch_rtnl pointers, so
> ops_undo_list() can figure out whether its worth taking rtnl all by itself ?

Either way -- this would fit quite nicely as its own patch so please
follow up if you agree. I'll apply the series as is.