netdev - Re: [PATCH net-next 01/15] devlink: add value check to devlink_info_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8dee9f0d-9fb0-41b1-acd1-2ed2a5322610@intel.com>
Date: Tue, 15 Apr 2025 09:53:13 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Edward Cree <ecree.xilinx@...il.com>, "Nelson, Shannon"
	<shannon.nelson@....com>, "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>, "Dumazet,
 Eric" <edumazet@...gle.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "horms@...nel.org" <horms@...nel.org>, "corbet@....net"
	<corbet@....net>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, "R, Bharath"
	<bharath.r@...el.com>
Subject: Re: [PATCH net-next 01/15] devlink: add value check to
 devlink_info_version_put()


> Unrelated (I think?) this is a relatively big series so I don't want
> to race with it, but I think we should rename the defines.

you are right that this is unrelated but conflicting :)

> 
> DEVLINK_INFO_VERSION_GENERIC_x -> DEVLINK_VER_x ?
> 
> You did some major devlink refactors, maybe you want to take this on? :)
> The 40 char defines lead to pretty ugly wrapping, and make constructs
> like:
> 
> 	if (something)
> 		devlink_info_version_running_put(...
> 
> impossible. We could also rename the helpers to s/_version// ..

sure, I have also one more refactor idea around this family of functions
so it would fit well :)