netdev - Re: [PATCH RESEND v2 net-next 06/14] ipv6: Split ip6_route_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9903a135-1f30-4a76-9c14-36159eb413d6@redhat.com>
Date: Wed, 16 Apr 2025 11:12:31 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 06/14] ipv6: Split
 ip6_route_info_create().

On 4/14/25 8:14 PM, Kuniyuki Iwashima wrote:
> We will get rid of RTNL from RTM_NEWROUTE and SIOCADDRT and rely
> on RCU to guarantee dev and nexthop lifetime.
> 
> Then, we want to allocate everything as possible before entering

Then, we want to allocate everything before ...

or

Then, we want to allocate as much as possible before ...

> the RCU section.
> 
> The RCU section will start in the middle of ip6_route_info_create(),
> and this is problematic for ip6_route_multipath_add() that calls
> ip6_route_info_create() multiple times.
> 
> Let's split ip6_route_info_create() into two parts; one for memory
> allocation and another for nexthop setup.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Acked-by: Paolo Abeni <pabeni@...hat.com>