netdev - Re: [PATCH net 7/8] netlink: specs: rt-link: adjust mctp attribute naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2h62ol8lu.fsf@gmail.com>
Date: Wed, 16 Apr 2025 11:10:53 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org,
  daniel@...earbox.net,  sdf@...ichev.me,  jacob.e.keller@...el.com
Subject: Re: [PATCH net 7/8] netlink: specs: rt-link: adjust mctp attribute
 naming

Jakub Kicinski <kuba@...nel.org> writes:

> MCTP attribute naming is inconsistent. In C we have:
>     IFLA_MCTP_NET,
>     IFLA_MCTP_PHYS_BINDING,
>          ^^^^
>
> but in YAML:
>     - mctp-net
>     - phys-binding
>       ^
>        no "mctp"
>
> It's unclear whether the "mctp" part of the name is supposed
> to be a prefix or part of attribute name. Make it a prefix,
> seems cleaner, even tho technically phys-binding was added later.
>
> Fixes: b2f63d904e72 ("doc/netlink: Add spec for rt link messages")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>