netdev - Re: [RFG] sfc: nvlog and devlink health

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <t255xnzuddoio4da3eiv7se27xvb6hvi7qkvflwpa5p3sa5qor@tpnrxyam4ock>
Date: Wed, 16 Apr 2025 13:27:22 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [RFG] sfc: nvlog and devlink health

Wed, Apr 16, 2025 at 12:24:07PM +0200, ecree.xilinx@...il.com wrote:
>On 15/04/2025 17:41, Jiri Pirko wrote:
>> Tue, Apr 15, 2025 at 04:51:39PM +0200, ecree.xilinx@...il.com wrote:
>>> DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR is no use here, because it only
>>> clears the kernel-saved copy; it doesn't call any driver method.
>> 
>> Can't it be extended to actually call an optional driver method?
>> That would sound fine to me and will solve your problem.
>
>Would that be "diagnose"/"dump clear" or "dump"/"dump clear"?
>The former is weird, are you sure it's not a misuse of the API to
> have "dump clear" clear something that's not a dump?  I feel like
> extending the devlink core to support a semantic mismatch /
> layering violation might raise a few eyebrows.

I probably misunderstood. I thought you wrote that it is the dump that
is actually cleared.


>The latter just doesn't work as (afaict) calling dump twice
> without an intervening clear won't get updated output, and users
> might want to read again without erasing.