netdev - Re: [PATCH net 1/8] tools: ynl-gen: don't declare loop iterator in place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416064505.220f26e8@kernel.org>
Date: Wed, 16 Apr 2025 06:45:05 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 daniel@...earbox.net, sdf@...ichev.me, jacob.e.keller@...el.com
Subject: Re: [PATCH net 1/8] tools: ynl-gen: don't declare loop iterator in
 place

On Wed, 16 Apr 2025 11:06:39 +0100 Donald Hunter wrote:
> >  def put_req_nested(ri, struct):
> > +    local_vars = []
> > +    init_lines = []
> > +
> > +    local_vars.append('struct nlattr *nest;')
> > +    init_lines.append("nest = ynl_attr_nest_start(nlh, attr_type);")  
> 
> Minor nit: the series uses += ['...'] elsewhere, is it worth being
> consistent?

Agreed, it was annoying me too.. but in _multi_parse() I seem to have
used .append() in the exact same scenario. Hard to define "consistent"
in this code base :(