netdev - Re: [PATCH bpf] selftests/bpf: mitigate sockmap_ktls disconnect_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edd05a3ce17ed40c179a076750261f02cb3e314e@linux.dev>
Date: Wed, 16 Apr 2025 17:39:45 +0000
From: "Jiayuan Chen" <jiayuan.chen@...ux.dev>
To: "Ihor Solodrai" <ihor.solodrai@...ux.dev>, ast@...nel.org,
 andrii@...nel.org, daniel@...earbox.net, eddyz87@...il.com
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, kuba@...nel.org,
 pabeni@...hat.com, mykolal@...com, kernel-team@...a.com
Subject: Re: [PATCH bpf] selftests/bpf: mitigate sockmap_ktls
 disconnect_after_delete failure

April 17, 2025 at 01:02, "Ihor Solodrai" <ihor.solodrai@...ux.dev> wrote:

> 
> "sockmap_ktls disconnect_after_delete" test has been failing on BPF CI
> 
> after recent merges from netdev:
> 
> * https://github.com/kernel-patches/bpf/actions/runs/14458537639
> 
> * https://github.com/kernel-patches/bpf/actions/runs/14457178732
> 
> It happens because disconnect has been disabled for TLS [1], and it
> 
> renders the test case invalid.
> 
> Removing all the test code creates a conflict between bpf and
> 
> bpf-next, so for now only remove the offending assert [2].
> 
> The test will be removed later on bpf-next.
> 
> [1] https://lore.kernel.org/netdev/20250404180334.3224206-1-kuba@kernel.org/
> 
> [2] https://lore.kernel.org/bpf/cfc371285323e1a3f3b006bfcf74e6cf7ad65258@linux.dev/
> 
> Signed-off-by: Ihor Solodrai <ihor.solodrai@...ux.dev>

Reviewed-by: Jiayuan Chen <jiayuan.chen@...ux.dev>

Thanks.

> ---
> 
>  tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c | 1 -
> 
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> 
> index 2d0796314862..0a99fd404f6d 100644
> 
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> 
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> 
> @@ -68,7 +68,6 @@ static void test_sockmap_ktls_disconnect_after_delete(int family, int map)
> 
>  goto close_cli;
> 
>  
> 
>  err = disconnect(cli);
> 
> - ASSERT_OK(err, "disconnect");
> 
>  
> 
>  close_cli:
> 
>  close(cli);
> 
> -- 
> 
> 2.49.0
>