netdev - Re: [PATCH v2 6/8] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416015257.36336-1-kuniyu@amazon.com>
Date: Tue, 15 Apr 2025 18:52:52 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <jlayton@...nel.org>
CC: <akpm@...ux-foundation.org>, <andrew@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <horms@...nel.org>, <kuba@...nel.org>,
	<kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>, <nathan@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <qasdev00@...il.com>
Subject: Re: [PATCH v2 6/8] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking

From: Jeff Layton <jlayton@...nel.org>
Date: Tue, 15 Apr 2025 14:49:44 -0400
> After assigning the inode number to the namespace, use it to create a
> unique name for each netns refcount tracker and register the debugfs
> files for them.
> 
> The init_net is registered early in the boot process before the
> ref_tracker dir is created, so add a late_initcall() to register its
> files.
> 
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
>  net/core/net_namespace.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index 4303f2a4926243e2c0ff0c0387383cd8e0658019..f636eb9b8eba28114fd192d64bcd359a25381988 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -761,12 +761,44 @@ struct net *get_net_ns_by_pid(pid_t pid)
>  }
>  EXPORT_SYMBOL_GPL(get_net_ns_by_pid);
>  
> +#ifdef CONFIG_NET_NS_REFCNT_TRACKER
> +static void net_ns_net_debugfs(struct net *net)
> +{
> +	char name[32];

Perhaps define REF_TRACKER_NAMESZ (I'm really bad at naming) and reuse
it in the next two patches ?

Otherwise looks good to me.

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>