netdev - Re: [PATCH v3 net 4/4] pds_core: make wait_context part of q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e61e6355-6782-4b78-a085-3a616c0afa23@intel.com>
Date: Wed, 16 Apr 2025 13:16:37 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shannon Nelson <shannon.nelson@....com>, <andrew+netdev@...n.ch>,
	<brett.creeley@....com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <michal.swiatkowski@...ux.intel.com>,
	<horms@...nel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net 4/4] pds_core: make wait_context part of q_info



On 4/15/2025 4:29 PM, Shannon Nelson wrote:
> Make the wait_context a full part of the q_info struct rather
> than a stack variable that goes away after pdsc_adminq_post()
> is done so that the context is still available after the wait
> loop has given up.
> 
> There was a case where a slow development firmware caused
> the adminq request to time out, but then later the FW finally
> finished the request and sent the interrupt.  The handler tried
> to complete_all() the completion context that had been created
> on the stack in pdsc_adminq_post() but no longer existed.
> This caused bad pointer usage, kernel crashes, and much wailing
> and gnashing of teeth.

Ugh, I can imagine that was hard to track down..

> 
> Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands")
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> ---
Yea, this approach seems a bit cleaner overall too!

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>