[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACKFLi=tvPJXk4zFXxFzWftc-AVU+2m_cg+EFTzs5MSoDoWFaQ@mail.gmail.com>
Date: Wed, 16 Apr 2025 14:41:10 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com, andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
andrew.gospodarek@...adcom.com,
Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net-next 1/4] bnxt_en: Change FW message timeout warning
On Tue, Apr 15, 2025 at 8:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
> sysctl_hung_task_timeout_secs is an exported symbol, and it defaults to 120.
> Should you not use it in the warning (assuming I understand the intent
> there)?
Yes, we have considered that. This is only printed once at driver
load time, but the sysctl value can be changed at any time after the
driver is loaded. So we just want to use a reasonable value well
below the default sysctl_hung_task_timeout_secs value as the
threshold.
But we can reference and compare with the
sysctl_hung_task_timeout_secs value if that makes more sense.
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)
Powered by blists - more mailing lists