netdev - Re: [PATCH v0] net: ethtool: Only set supplied eee ethtool settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6694f2c8-cfc8-41ed-9ceb-3e0b10aec6b9@lunn.ch>
Date: Thu, 17 Apr 2025 00:36:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rutger van Kruiningen <rutger.vankruiningen@...iedtelesis.co.nz>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v0] net: ethtool: Only set supplied eee ethtool settings

On Thu, Apr 17, 2025 at 10:12:30AM +1200, Rutger van Kruiningen wrote:
> Originally all ethtool eee setting updates were attempted even if the
> settings were not supplied, causing a null pointer crash.
> 
> Add check for each eee setting and only update if it exists.

I see what you mean, but i'm somewhat surprised we have not seen this
crash. Do you have a simple reproducer? I just did

ethtool --debug 255 --set-eee eth0 eee on

and it did not crash, despite:

sending genetlink packet (44 bytes):
    msg length 44 ethool ETHTOOL_MSG_EEE_SET
    ETHTOOL_MSG_EEE_SET
        ETHTOOL_A_EEE_HEADER
            ETHTOOL_A_HEADER_DEV_NAME = "eth0"
        ETHTOOL_A_EEE_ENABLED = on

So it only provided ETHTOOL_A_EEE_ENABLED and none of the others.

	Andrew