netdev - Re: [PATCH]nfc: replace improper check device_is_registered() in nfc_se

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250416024454.319-1-chenyufeng@iie.ac.cn>
Date: Wed, 16 Apr 2025 10:44:54 +0800
From: Chen Yufeng <chenyufeng@....ac.cn>
To: kuba@...nel.org
Cc: chenyufeng@....ac.cn,
	davem@...emloft.net,
	edumazet@...gle.com,
	horms@...nel.org,
	krzk@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH]nfc: replace improper check device_is_registered() in nfc_se_io()

> On Tue, 15 Apr 2025 10:54:36 +0800 Chen Yufeng wrote:
> > > On 14/04/2025 16:11, Chen Yufeng wrote:  
> > > > A patch similar to commit da5c0f119203 ("nfc: replace improper check device_is_registered() in netlink related functions")  
> > 
> > > Please wrap commit message according to Linux coding style / submission
> > > process (neither too early nor over the limit):
> > > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597  
> > 
> > Thanks for your reply!
> > I have reorganized commit message as follows.
> > 
> > A patch similar to commit da5c0f119203 ("nfc: replace improper check 
> > device_is_registered() in netlink related functions").
> > 
> > The nfc_se_io() function in the NFC subsystem suffers from a race 
> > condition similar to previously reported issues in other netlink-related 
> > functions. The function checks device status using device_is_registered(),
> > but this check can race with device unregistration despite being protected
> > by device_lock.
> > 
> > This patch also uses bool variable dev->shutting_down instead of
> > device_is_registered() to judge whether the nfc device is registered,
> > which is well synchronized.
> 
> You're also missing a Fixes tag

Thanks for your reply. I have added the Fixes tag.
Fixes: cd96db6fd0ac ("NFC: Add se_io NFC operand")
--
Thanks, 

Chen Yufeng